-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
135 calc_*
functions should output NAs is there is no available data
#141
135 calc_*
functions should output NAs is there is no available data
#141
Conversation
partially addresses #133 |
@kdaust it seems check are failing because the server can't be reached. Any clues as to what might be happening? |
Should be fixed now - not sure why but postgres quit. Has been happening if someone uses the old climRdev and requests a large area. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devl #141 +/- ##
==========================================
+ Coverage 5.48% 46.14% +40.66%
==========================================
Files 21 22 +1
Lines 1659 1688 +29
==========================================
+ Hits 91 779 +688
+ Misses 1568 909 -659 ☔ View full report in Codecov by Sentry. |
@kdaust the checks keep failing due to server issues. Can you check the failing test code and see if I'm doing anything wrong that could be triggering server issues? |
Do you know which tests are causing the fail? Is it the calc_* function test? Also, would it make sense to focus on the main climr_downscale function, instead of using the underlying functions directly? Although I suppose it doesn't matter for testing the calculations |
I tried running the test and it ran fine - I wonder if the problem is being caused by multiple instances trying to pull from the database at the same time? You're downloading the entire prism surface of BC, so that's fairly large. Maybe try using a much smaller bounding box for the tests and see if that works? |
It is the second test that fails. As to the size of the bbox, I was using what was available in |
#135
Tests for
calc_*
functions could evolve into comparing with data from ClimateBC. This is a start, though.To be continued...